Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756484Ab3HLNf2 (ORCPT ); Mon, 12 Aug 2013 09:35:28 -0400 Received: from g4t0016.houston.hp.com ([15.201.24.19]:48844 "EHLO g4t0016.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755930Ab3HLNf0 (ORCPT ); Mon, 12 Aug 2013 09:35:26 -0400 Message-ID: <1376314512.3364.1.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH v2 05/20] mm, hugetlb: grab a page_table_lock after page_cache_release From: Davidlohr Bueso To: Joonsoo Kim Cc: Andrew Morton , Rik van Riel , Mel Gorman , Michal Hocko , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Wanpeng Li , Naoya Horiguchi , Hillf Danton Date: Mon, 12 Aug 2013 06:35:12 -0700 In-Reply-To: <1376040398-11212-6-git-send-email-iamjoonsoo.kim@lge.com> References: <1376040398-11212-1-git-send-email-iamjoonsoo.kim@lge.com> <1376040398-11212-6-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 35 On Fri, 2013-08-09 at 18:26 +0900, Joonsoo Kim wrote: > We don't need to grab a page_table_lock when we try to release a page. > So, defer to grab a page_table_lock. > > Reviewed-by: Naoya Horiguchi > Signed-off-by: Joonsoo Kim Reviewed-by: Davidlohr Bueso > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index c017c52..6c8eec2 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2627,10 +2627,11 @@ retry_avoidcopy: > } > spin_unlock(&mm->page_table_lock); > mmu_notifier_invalidate_range_end(mm, mmun_start, mmun_end); > - /* Caller expects lock to be held */ > - spin_lock(&mm->page_table_lock); > page_cache_release(new_page); > page_cache_release(old_page); > + > + /* Caller expects lock to be held */ > + spin_lock(&mm->page_table_lock); > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/