Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757530Ab3HLRY1 (ORCPT ); Mon, 12 Aug 2013 13:24:27 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:35995 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757279Ab3HLRYX convert rfc822-to-8bit (ORCPT ); Mon, 12 Aug 2013 13:24:23 -0400 Subject: Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=US-ASCII From: Kumar Gala In-Reply-To: Date: Mon, 12 Aug 2013 12:24:28 -0500 Cc: Grant Likely , "linux-kernel@vger.kernel.org list" , "linux-arm-msm@vger.kernel.org" , devicetree@vger.kernel.org, Jeffrey Hugo , Stephen Boyd , Eric Holmberg Content-Transfer-Encoding: 7BIT Message-Id: <9BC13262-0803-4790-B1B5-0B46F7DB8D30@codeaurora.org> References: <1375128719-23642-1-git-send-email-galak@codeaurora.org> <20130729214035.GC8868@codeaurora.org> <9EB1A821-7137-4812-B58A-20F669BCA7DD@codeaurora.org> <0A09DA0F-86B4-4961-88E2-64FA0A4D380D@codeaurora.org> To: Ohad Ben-Cohen X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2576 Lines: 74 On Aug 10, 2013, at 2:11 PM, Ohad Ben-Cohen wrote: > + Grant > > On Thu, Aug 1, 2013 at 5:10 PM, Kumar Gala wrote: >>> On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: >>>> On 07/29, Kumar Gala wrote: >>>>>> diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt >>>>>> new file mode 100644 >>>>>> index 0000000..ddd6889 >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt >>>> >>>> Maybe this should go under a new hwspinlock directory? >>> >>> Will look for Ohad to comment on this. >>> >>>> >>>>>> @@ -0,0 +1,20 @@ >>>>>> +Qualcomm MSM Hardware Mutex Block: >>>>>> + >>>>>> +The hardware block provides mutexes utilized between different processors >>>>>> +on the SoC as part of the communication protocol used by these processors. >>>>>> + >>>>>> +Required properties: >>>>>> +- compatible: should be "qcom,tcsr-mutex" >>>>>> +- reg: Should contain registers location and length of mutex registers >>>>>> +- reg-names: >>>>>> + "mutex-base" - string to identify mutex registers >>>>>> +- qcom,num-locks: the number of locks/mutexes supported >>>>>> + >>>>>> +Example: >>>>>> + >>>>>> + qcom,tcsr-mutex@fd484000 { >>>> >>>> Maybe it should be hw-mutex@fd484000? >>> >>> again, will look for Ohad to make some comment on this. >>> >>>>>> + compatible = "qcom,tcsr-mutex"; >>>>>> + reg = <0xfd484000 0x1000>; >>>>>> + reg-names = "mutex-base"; >>>>>> + qcom,num-locks = <32>; >>>>>> + }; >> >> Ohad, ping. > > I'd prefer a DT maintainer to take a look at your two open questions > above, especially if I'm to merge a new file into the devicetree > Documentation folder. > > Grant, any chance you have a moment to take a look? > > Otherwise, Stephen - do we have your Ack here? I was happy to see your > review but not sure what's the latest status. > > Thanks, > Ohad. > -- So I think I'd ask you to recommend a name, should we just us 'hwspinlock'. The general view from ePAPR and dts is the node name should be a bit more generic (like ethernet or pci). So what would you suggest? - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/