Date: Mon, 12 Aug 2013 15:16:32 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>, Christoph Lameter <cl@gentwo.org>,
        David Daney <ddaney.cavm@gmail.com>, <linux-kernel@vger.kernel.org>,
        Chris Metcalf <cmetcalf@tilera.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] smp.c: Quit unconditionally enabling irqs in
 on_each_cpu_mask().
Message-Id: <20130812151632.c787db7072bc4d93b43c1066@linux-foundation.org>
In-Reply-To: <52054208.4040201@caviumnetworks.com>
References: <1375986342-22999-1-git-send-email-ddaney.cavm@gmail.com>
	<000001405f6459b8-32fb5ffe-837b-41be-bec4-c9c05fd4f114-000000@email.amazonses.com>
	<5203FF48.7000903@caviumnetworks.com>
	<CAOtvUMcR2Hx2jMy6Y0QQv5h7dM2a5fAC_M7BpgnaLa0VUieEHg@mail.gmail.com>
	<52054208.4040201@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 22

On Fri, 9 Aug 2013 12:24:56 -0700 David Daney <ddaney@caviumnetworks.com> wrote:

> > otherwise the bugs
> > stemming from incorrect use can be tricky to catch.
> >
> 
> ... all my patch does is allow on_each_cpu_mask() to be called with IRQs 
> disabled if we are in Early Boot.  This is already the case with 
> smp_call_function(), smp_call_function_many() and on_each_cpu().  I am 
> arguing that for the sake of consistency and the principle that function 
> behavior shouldn't be surprising, that we make on_each_cpu_mask() work 
> the same way.

Yup, the check in smp_call_function_many() will tell us if anyone calls
on_each_cpu_mask() with interrupts disabled any time after boot.

The whole early_boot_irqs_disabled thing is of course totally vile :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/