Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756234Ab3HMAUd (ORCPT ); Mon, 12 Aug 2013 20:20:33 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:40330 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756049Ab3HMAUc (ORCPT ); Mon, 12 Aug 2013 20:20:32 -0400 Message-ID: <52097BAE.3010103@ti.com> Date: Mon, 12 Aug 2013 19:19:58 -0500 From: Joel Fernandes User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: CC: Sekhar Nori , Santosh Shilimkar , Sricharan R , Rajendra Nayak , Lokesh Vutla , Matt Porter , Vinod Koul , Dan Williams , Russell King , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List Subject: Re: [PATCH v3 01/12] dma: edma: Setup parameters to DMA MAX_NR_SG at a time References: <1375719297-12871-1-git-send-email-joelf@ti.com> <1375719297-12871-2-git-send-email-joelf@ti.com> <52088B8B.9040000@ti.com> <52097604.7010503@ti.com> In-Reply-To: <52097604.7010503@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2206 Lines: 60 On 08/12/2013 06:55 PM, Joel Fernandes wrote: > Dropped quite a few from the CC list... > > On 08/12/2013 02:15 AM, Sekhar Nori wrote: >> On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: >>> Changes are made here for configuring existing parameters to support >>> DMA'ing them out in batches as needed. >>> >>> Also allocate as many as slots as needed by the SG list, but not more >>> than MAX_NR_SG. Then these slots will be reused accordingly. >>> For ex, if MAX_NR_SG=10, and number of SG entries is 40, still only >>> 10 slots will be allocated to DMA the entire SG list of size 40. >>> >>> Signed-off-by: Joel Fernandes >>> --- >>> drivers/dma/edma.c | 14 +++++++++++--- >>> 1 file changed, 11 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c >>> index 5f3e532..7b0853c 100644 >>> --- a/drivers/dma/edma.c >>> +++ b/drivers/dma/edma.c >>> @@ -222,9 +222,9 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( >>> enum dma_slave_buswidth dev_width; >>> u32 burst; >>> struct scatterlist *sg; >>> - int i; >>> int acnt, bcnt, ccnt, src, dst, cidx; >>> int src_bidx, dst_bidx, src_cidx, dst_cidx; >>> + int i, num_slots_needed; >> >> 'nslots' is more to my liking. Better keep variable names short. >> >>> >>> if (unlikely(!echan || !sgl || !sg_len)) >>> return NULL; >>> @@ -262,8 +262,11 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( >>> >>> edesc->pset_nr = sg_len; >>> >>> - for_each_sg(sgl, sg, sg_len, i) { >>> - /* Allocate a PaRAM slot, if needed */ >>> + /* Allocate a PaRAM slot, if needed */ >>> + >>> + num_slots_needed = sg_len > MAX_NR_SG ? MAX_NR_SG : sg_len; >> >> nslots = min(MAX_NR_SG, sg_len); > > I agree the original naming was quite long. I would rather using > something more descriptive though than nslots. How does slots_needed sound? Sorry for the noise, nslots is fine and I've changed it to the same. -Joel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/