Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756420Ab3HMBBA (ORCPT ); Mon, 12 Aug 2013 21:01:00 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:37793 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756245Ab3HMBA7 convert rfc822-to-8bit (ORCPT ); Mon, 12 Aug 2013 21:00:59 -0400 Subject: Re: [PATCH v5] media: i2c: tvp7002: add OF support Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <1376202321-25175-1-git-send-email-prabhakar.csengg@gmail.com> Date: Mon, 12 Aug 2013 20:00:55 -0500 Cc: LMML , Hans Verkuil , DLOS , LKML , Mauro Carvalho Chehab , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1376202321-25175-1-git-send-email-prabhakar.csengg@gmail.com> To: "Lad, Prabhakar" X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3194 Lines: 107 On Aug 11, 2013, at 1:25 AM, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > > add OF support for the tvp7002 driver. > > Signed-off-by: Lad, Prabhakar > --- > This patch depends on https://patchwork.kernel.org/patch/2842680/ > > Changes for v5: > 1: Fixed review comments pointed by Hans. > > Changes for v4: > 1: Improved descrition of end point properties. > > Changes for v3: > 1: Fixed review comments pointed by Sylwester. > > .../devicetree/bindings/media/i2c/tvp7002.txt | 53 ++++++++++++++++ > drivers/media/i2c/tvp7002.c | 67 ++++++++++++++++++-- > 2 files changed, 113 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/i2c/tvp7002.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/tvp7002.txt b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt > new file mode 100644 > index 0000000..5f28b5d > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt > @@ -0,0 +1,53 @@ > +* Texas Instruments TV7002 video decoder > + > +The TVP7002 device supports digitizing of video and graphics signal in RGB and > +YPbPr color space. > + > +Required Properties : > +- compatible : Must be "ti,tvp7002" > + > +Optional Properties: > +- hsync-active: HSYNC Polarity configuration for the bus. Default value when > + this property is not specified is <0>. > + > +- vsync-active: VSYNC Polarity configuration for the bus. Default value when > + this property is not specified is <0>. > + > +- pclk-sample: Clock polarity of the bus. Default value when this property is > + not specified is <0>. > + > +- sync-on-green-active: Active state of Sync-on-green signal property of the > + endpoint. > + 0 = Normal Operation (Active Low, Default) > + 1 = Inverted operation These seems better than what you have in video-interfaces.txt > + > +- field-even-active: Active-high Field ID output polarity control of the bus. > + Under normal operation, the field ID output is set to logic 1 for an odd field > + (field 1) and set to logic 0 for an even field (field 0). > + 0 = Normal Operation (Active Low, Default) > + 1 = FID output polarity inverted > + Why the duplication if this is covered in video-interfaces.txt? > +For further reading of port node refer Documentation/devicetree/bindings/media/ > +video-interfaces.txt. > + > +Example: > + > + i2c0@1c22000 { > + ... > + ... > + tvp7002@5c { > + compatible = "ti,tvp7002"; > + reg = <0x5c>; > + > + port { > + tvp7002_1: endpoint { > + hsync-active = <1>; > + vsync-active = <1>; > + pclk-sample = <0>; > + sync-on-green-active = <1>; > + field-even-active = <0>; > + }; > + }; > + }; > + ... > + }; > [ snip ] - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/