Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755575Ab3HMHOH (ORCPT ); Tue, 13 Aug 2013 03:14:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:47725 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187Ab3HMHOG (ORCPT ); Tue, 13 Aug 2013 03:14:06 -0400 Message-ID: <5209DCB9.8020705@linutronix.de> Date: Tue, 13 Aug 2013 09:14:01 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: Sergei Shtylyov CC: Bin Liu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, george.cherian@ti.com Subject: Re: [PATCH] usb: musb: am335x: Do not remove the session bin HOST-only mode References: <51F2BE6F.3010008@linutronix.de> <51F2D427.7050106@linutronix.de> <51F2DD90.2030405@linutronix.de> <20130729165329.GA5773@linutronix.de> <51F6ABA2.7060102@linutronix.de> <20130809160339.GA14829@linutronix.de> <5205516D.1030707@cogentembedded.com> In-Reply-To: <5205516D.1030707@cogentembedded.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 635 Lines: 20 On 08/09/2013 10:30 PM, Sergei Shtylyov wrote: > Hello. Hi Sergei, >> + if (musb->port_mode == MUSB_PORT_MODE_HOST) { >> + val = USBMODE_IDDIG_A; >> + val |= USBMODE_ID_MUX_REG; > > Why not do the above in one line and save on {} {}? It will look more > aesthetically pleasing IMHO. I'm going to redo this if it is agreed that we want to fix it that way. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/