Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758967Ab3HMRZx (ORCPT ); Tue, 13 Aug 2013 13:25:53 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:24722 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758572Ab3HMRZF (ORCPT ); Tue, 13 Aug 2013 13:25:05 -0400 From: Rupesh Gujare To: CC: , , , Subject: [PATCH 03/10] staging: ozwpan: Simply if condition Date: Tue, 13 Aug 2013 18:24:23 +0100 Message-ID: <1376414670-23257-4-git-send-email-rupesh.gujare@atmel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1376414670-23257-1-git-send-email-rupesh.gujare@atmel.com> References: <1376414670-23257-1-git-send-email-rupesh.gujare@atmel.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 45 Making code simpler for readability. Reported-by: Dan Carpenter Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 5a417c8..4b658d4 100644 --- a/drivers/staging/ozwpan/ozhcd.c +++ b/drivers/staging/ozwpan/ozhcd.c @@ -478,7 +478,7 @@ static int oz_enqueue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir, struct urb *urb, u8 req_id) { struct oz_urb_link *urbl; - struct oz_endpoint *ep; + struct oz_endpoint *ep = NULL; int err = 0; if (ep_addr >= OZ_NB_ENDPOINTS) { @@ -506,11 +506,12 @@ static int oz_enqueue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir, oz_free_urb_link(urbl); return 0; } - if (in_dir && port->in_ep[ep_addr]) + + if (in_dir) ep = port->in_ep[ep_addr]; - else if (!in_dir && port->out_ep[ep_addr]) + else ep = port->out_ep[ep_addr]; - else { + if (!ep) { err = -ENOMEM; goto out; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/