Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758322Ab3HMRkU (ORCPT ); Tue, 13 Aug 2013 13:40:20 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:26231 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757248Ab3HMRkS (ORCPT ); Tue, 13 Aug 2013 13:40:18 -0400 Message-ID: <520A6F75.8010308@atmel.com> Date: Tue, 13 Aug 2013 18:40:05 +0100 From: Rupesh Gujare User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Sergei Shtylyov CC: , , , , Subject: Re: [PATCH 07/10] staging: ozwpan: Make oz_hcd_pd_departed() take a struct pointer. References: <1376414966-23525-1-git-send-email-rupesh.gujare@atmel.com> <1376414966-23525-3-git-send-email-rupesh.gujare@atmel.com> <520A6E5B.3020303@cogentembedded.com> In-Reply-To: <520A6E5B.3020303@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 48 On 13/08/13 18:35, Sergei Shtylyov wrote: > Hello. > > On 08/13/2013 09:29 PM, Rupesh Gujare wrote: > >> oz_hcd_pd_departed() takes struct oz_port pointer instead of >> void *, change function declaration to avoid ambiguity. > >> Reported-by: Dan Carpenter >> Signed-off-by: Rupesh Gujare >> --- >> drivers/staging/ozwpan/ozhcd.c | 4 ++-- >> drivers/staging/ozwpan/ozhcd.h | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > >> diff --git a/drivers/staging/ozwpan/ozhcd.c >> b/drivers/staging/ozwpan/ozhcd.c >> index 73d80f2..ed3ffeb 100644 >> --- a/drivers/staging/ozwpan/ozhcd.c >> +++ b/drivers/staging/ozwpan/ozhcd.c >> @@ -720,9 +720,9 @@ out: >> * polled. We release the reference we hold on the PD. >> * Context: softirq >> */ >> -void oz_hcd_pd_departed(void *hport) >> +void oz_hcd_pd_departed(struct oz_port *hport) >> { >> - struct oz_port *port = (struct oz_port *)hport; >> + struct oz_port *port = hport; > > Do you really need a copy? Isn't it better to rename the parameter > and remove this line altogether? > > WBR, Sergei > Yes, that is the idea, for next patch series, as I don't want to mix two changes in single patch. -- Regards, Rupesh Gujare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/