Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758966Ab3HMUC5 (ORCPT ); Tue, 13 Aug 2013 16:02:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37843 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758861Ab3HMUCz (ORCPT ); Tue, 13 Aug 2013 16:02:55 -0400 Message-ID: <520A90E9.7080206@suse.cz> Date: Tue, 13 Aug 2013 22:02:49 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andi Kleen Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andi Kleen , Rusty Russell Subject: Re: [PATCH] Handle non ABS crc symbols References: <1376077524-27573-1-git-send-email-andi@firstfloor.org> In-Reply-To: <1376077524-27573-1-git-send-email-andi@firstfloor.org> X-Enigmail-Version: 1.6a1pre Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 55 Added Rusty to CC. Dne 9.8.2013 21:45, Andi Kleen napsal(a): > From: Andi Kleen > > For some reason I managed to trick gcc into create CRC symbols that > are not absolute anymore, but weak. > > Make modpost handle this case. > > Andrew, this should fix the bizarre warning. Seems like a toolchain > bug to me. > > Signed-off-by: Andi Kleen > --- > scripts/mod/modpost.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 6216434..b3dd735 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -599,18 +599,17 @@ static void handle_modversions(struct module *mod, struct elf_info *info, > else > export = export_from_sec(info, get_secindex(info, sym)); > > + /* CRC'd symbol */ > + if (strncmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) { > + crc = (unsigned int) sym->st_value; > + sym_update_crc(symname + strlen(CRC_PFX), mod, crc, > + export); > + } > + > switch (sym->st_shndx) { > case SHN_COMMON: > warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name); > break; > - case SHN_ABS: > - /* CRC'd symbol */ > - if (strncmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) { > - crc = (unsigned int) sym->st_value; > - sym_update_crc(symname + strlen(CRC_PFX), mod, crc, > - export); > - } > - break; > case SHN_UNDEF: > /* undefined symbol */ > if (ELF_ST_BIND(sym->st_info) != STB_GLOBAL && > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/