Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759427Ab3HNDkP (ORCPT ); Tue, 13 Aug 2013 23:40:15 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:13350 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759108Ab3HNDkM (ORCPT ); Tue, 13 Aug 2013 23:40:12 -0400 Message-ID: <520AFC05.7090909@huawei.com> Date: Wed, 14 Aug 2013 11:39:49 +0800 From: Libo Chen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: David Miller CC: , Greg KH , , LKML , Li Zefan Subject: [PATCH RESEND 5/8] net: sunbmac: use platform_{get,set}_drvdata() References: <5208E225.5040301@huawei.com> In-Reply-To: <5208E225.5040301@huawei.com> X-Forwarded-Message-Id: <5208E225.5040301@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.72.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 43 We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &of->dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. Signed-off-by: Libo Chen --- drivers/net/ethernet/sun/sunbmac.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c index 0d43fa9..34b94cc 100644 --- a/drivers/net/ethernet/sun/sunbmac.c +++ b/drivers/net/ethernet/sun/sunbmac.c @@ -1239,7 +1239,7 @@ static int bigmac_sbus_probe(struct platform_device *op) static int bigmac_sbus_remove(struct platform_device *op) { - struct bigmac *bp = dev_get_drvdata(&op->dev); + struct bigmac *bp = platform_get_drvdata(op); struct device *parent = op->dev.parent; struct net_device *net_dev = bp->dev; struct platform_device *qec_op; @@ -1259,7 +1259,6 @@ static int bigmac_sbus_remove(struct platform_device *op) free_netdev(net_dev); - dev_set_drvdata(&op->dev, NULL); return 0; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/