Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759514Ab3HNIWH (ORCPT ); Wed, 14 Aug 2013 04:22:07 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:36504 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759493Ab3HNIWD (ORCPT ); Wed, 14 Aug 2013 04:22:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376377766-2594-1-git-send-email-chenxg@marvell.com> Date: Wed, 14 Aug 2013 13:52:01 +0530 Message-ID: Subject: Re: [PATCH 1/2] cpufreq: Add governor operation ongoing flag From: Viresh Kumar To: Xiaoguang Chen Cc: Xiaoguang Chen , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "Rafael J. Wysocki" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 23 On 14 August 2013 13:49, Xiaoguang Chen wrote: > Yes, "START (If STOP passed)", this is important, we don't have this > patch on our code base, So even Process B's STOP failed(as governor > enable flag is set to false by process A already ), it can still do > START operation, So my problem occurs. > My problem is that I see ondemand governor is started twice during > frequent governor switch and cpu hotplug stress test. > > The After seeing your patch for the return value checking, I think my > problem should not occur. > This issue really botherred me for a long time. :( Exactly, the problem was users of this API were abusing it as they didn't cared for its return value. I hope that is fixed widely now and in case some places are still left, they should be fixed as well. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/