Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759575Ab3HNIyk (ORCPT ); Wed, 14 Aug 2013 04:54:40 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:58358 "EHLO mail-oa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759485Ab3HNIyh (ORCPT ); Wed, 14 Aug 2013 04:54:37 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376377766-2594-1-git-send-email-chenxg@marvell.com> Date: Wed, 14 Aug 2013 14:24:36 +0530 Message-ID: Subject: Re: [PATCH 1/2] cpufreq: Add governor operation ongoing flag From: Viresh Kumar To: Xiaoguang Chen Cc: Xiaoguang Chen , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "Rafael J. Wysocki" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 15 On 14 August 2013 14:20, Xiaoguang Chen wrote: > Hi, Viresh > After checking your patch, I find that __cpufreq_set_policy function > doesn't check STOP and EXIT 's return value > is it on purpose? if not, I can provide a patch to add it. I thought we probably can't break on these calls here, while we are trying to stop existing governor. And so didn't check return values.. If you face some issues with them, you are free to add checks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/