Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759594Ab3HNJEu (ORCPT ); Wed, 14 Aug 2013 05:04:50 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:47914 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759510Ab3HNJEr (ORCPT ); Wed, 14 Aug 2013 05:04:47 -0400 Message-ID: <520B482A.9060701@ti.com> Date: Wed, 14 Aug 2013 12:04:42 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Benoit Cousson CC: , , , , , , , , Subject: Re: [PATCH 6/7] ARM: dts: omap4: update omap-control-usb nodes References: <1375365915-21380-1-git-send-email-rogerq@ti.com> <1375365915-21380-7-git-send-email-rogerq@ti.com> <520B42B8.5080107@baylibre.com> In-Reply-To: <520B42B8.5080107@baylibre.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2811 Lines: 71 On 08/14/2013 11:41 AM, Benoit Cousson wrote: > Hi Roger, > > On 01/08/2013 16:05, Roger Quadros wrote: >> Split otghs_ctrl and USB2 PHY power down into separate >> omap-control-usb nodes. Update ti,mode property. > > Nit: I guess you mean ti,type? Right :). > >> CC: Benoit Cousson >> Signed-off-by: Roger Quadros >> --- >> arch/arm/boot/dts/omap4.dtsi | 17 ++++++++++++----- >> 1 files changed, 12 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi >> index 22d9f2b..9a6fa27 100644 >> --- a/arch/arm/boot/dts/omap4.dtsi >> +++ b/arch/arm/boot/dts/omap4.dtsi >> @@ -519,7 +519,7 @@ >> usb2_phy: usb2phy@4a0ad080 { >> compatible = "ti,omap-usb2"; >> reg = <0x4a0ad080 0x58>; >> - ctrl-module = <&omap_control_usb>; >> + ctrl-module = <&omap_control_usb2phy>; >> }; >> }; >> >> @@ -643,11 +643,17 @@ >> }; >> }; >> >> - omap_control_usb: omap-control-usb@4a002300 { >> + omap_control_usb2phy: omap-control-usb@4a002300 { >> compatible = "ti,omap-control-usb"; >> - reg = <0x4a002300 0x4>, >> - <0x4a00233c 0x4>; >> - reg-names = "control_dev_conf", "otghs_control"; >> + reg = <0x4a002300 0x4>; >> + reg-names = "power"; >> + ti,type = <2>; > > Now that we can use the C preprocessor, it will be nice to use a macro instead of the value. > > TYPE1 - if it has otghs_control mailbox register (e.g. on OMAP4) > TYPE2 - if it has Power down bit in control_dev_conf register. e.g. USB2 PHY > TYPE3 - if it has DPLL and individual Rx & Tx power control. e.g. USB3 PHY or SATA PHY > TYPE4 - if it has both power down and power aux registers. e.g. USB2 PHY on DRA7 > > Well, assuming you can find macro names that can explain a little bit what the type is about :-) > > That being said... > Do you really need to expose the type here? Maybe with just a set of different compatible string you can figure out in the driver what type we are talking about. > It is always better to minimize the amount of information we put in DT as soon as we can infer it from the compatible string. > > So instead of using a generic "ti,omap-control-usb" string + "ti,type" you can potentially use several specific strings: ti,omap4-control-usb, ti,dra7-control-usb... > Since the DT gurus are recommending to use specific compatible string as much as possible, this is maybe a better approach. > Good point. I'll get rid of the type altogether and use the compatible string instead. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/