Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759701Ab3HNKET (ORCPT ); Wed, 14 Aug 2013 06:04:19 -0400 Received: from mga14.intel.com ([143.182.124.37]:63195 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411Ab3HNKER (ORCPT ); Wed, 14 Aug 2013 06:04:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,876,1367996400"; d="scan'208";a="281792059" Date: Wed, 14 Aug 2013 14:52:00 +0530 From: Vinod Koul To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Dan Williams , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/29] dma: mmp: simplify use of devm_ioremap_resource Message-ID: <20130814092200.GN32147@intel.com> References: <1376471493-22215-1-git-send-email-Julia.Lawall@lip6.fr> <1376471493-22215-8-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376471493-22215-8-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 33 On Wed, Aug 14, 2013 at 11:11:11AM +0200, Julia Lawall wrote: > From: Julia Lawall > > Remove unneeded error handling on the result of a call to > platform_get_resource when the value is passed to devm_ioremap_resource. > > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression pdev,res,n,e,e1; > expression ret != 0; > identifier l; > @@ > > - res = platform_get_resource(pdev, IORESOURCE_MEM, n); > ... when != res > - if (res == NULL) { ... \(goto l;\|return ret;\) } > ... when != res > + res = platform_get_resource(pdev, IORESOURCE_MEM, n); > e = devm_ioremap_resource(e1, res); > // > > Signed-off-by: Julia Lawall Applied, thanks ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/