Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310Ab3HNMce (ORCPT ); Wed, 14 Aug 2013 08:32:34 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:37334 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188Ab3HNMcc (ORCPT ); Wed, 14 Aug 2013 08:32:32 -0400 MIME-Version: 1.0 In-Reply-To: <20130814121606.GB23840@n2100.arm.linux.org.uk> References: <1375741218-10225-1-git-send-email-sebastian.hesselbarth@gmail.com> <1375741218-10225-2-git-send-email-sebastian.hesselbarth@gmail.com> <20130814121606.GB23840@n2100.arm.linux.org.uk> Date: Wed, 14 Aug 2013 08:32:32 -0400 Message-ID: Subject: Re: [PATCH 1/8] drm/i2c: tda998x: fix EDID reading on TDA19988 devices From: Rob Clark To: Russell King - ARM Linux Cc: Sebastian Hesselbarth , David Airlie , Darren Etheridge , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 32 On Wed, Aug 14, 2013 at 8:16 AM, Russell King - ARM Linux wrote: > On Tue, Aug 06, 2013 at 12:20:11AM +0200, Sebastian Hesselbarth wrote: >> From: Russell King >> >> TDA19988 devices need their RAM enabled in order to read EDID >> information. Add support for this. >> >> Signed-off-by: Russell King >> Tested-by: Sebastian Hesselbarth > > There was some debate about whether this is needed or not. It seems that > if I don't run the NXP driver, it isn't needed, but if I have run the > NXP driver, then yes it is. As it seems to do no harm, I think it's fine > to be submitted. just fwiw, I had noticed before that (at least on the beaglebone-black), nxp doesn't necessarily get reset when doing a warm reboot. So booting a kernel w/ NXP driver, and then rebooting w/ upstream kernel and tda998x should probably hit this same scenario. Better to not assume too much about the state of the tda when the driver is loaded, so I think this patch is a good idea. Signed-off-by: Rob Clark BR, -R -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/