Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932872Ab3HNQoA (ORCPT ); Wed, 14 Aug 2013 12:44:00 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:53428 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932716Ab3HNQn6 (ORCPT ); Wed, 14 Aug 2013 12:43:58 -0400 MIME-Version: 1.0 In-Reply-To: <538b0cb147d3bd4a5e21b49c507f725f7fb7feb9.1375279948.git.viresh.kumar@linaro.org> References: <538b0cb147d3bd4a5e21b49c507f725f7fb7feb9.1375279948.git.viresh.kumar@linaro.org> Date: Wed, 14 Aug 2013 18:43:57 +0200 Message-ID: Subject: Re: [PATCH 04/15] cpufreq: dbx500: initialize .owner field with THIS_MODULE From: Linus Walleij To: Viresh Kumar Cc: "Rafael J. Wysocki" , linaro-kernel , Patch Tracking , cpufreq@vger.kernel.org, "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 24 On Wed, Jul 31, 2013 at 4:19 PM, Viresh Kumar wrote: > CPUFreq core does following at multiple places: > module_{get|put}(cpufreq_driver->owner)). > > This is done to make sure module doesn't get unloaded if it is currently in use. > This will work only if the .owner field of cpufreq driver is initialized with a > valid pointer. > > This field wasn't initialized for this driver, lets initialize it with > THIS_MODULE. > > Cc: Linus Walleij > Signed-off-by: Viresh Kumar Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/