Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760400Ab3HNSfZ (ORCPT ); Wed, 14 Aug 2013 14:35:25 -0400 Received: from mail-vc0-f169.google.com ([209.85.220.169]:51807 "EHLO mail-vc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760262Ab3HNSfV (ORCPT ); Wed, 14 Aug 2013 14:35:21 -0400 MIME-Version: 1.0 In-Reply-To: <20130814182756.GD24033@dhcp22.suse.cz> References: <52050382.9060802@gmail.com> <520BB225.8030807@gmail.com> <20130814174039.GA24033@dhcp22.suse.cz> <20130814182756.GD24033@dhcp22.suse.cz> Date: Wed, 14 Aug 2013 11:35:20 -0700 X-Google-Sender-Auth: Qu5SKpg4o4muJrbj3e7Q2Tet6MA Message-ID: Subject: Re: [Bug] Reproducible data corruption on i5-3340M: Please revert 53a59fc67! From: Linus Torvalds To: Michal Hocko Cc: Ben Tebulin , Mel Gorman , Johannes Weiner , Balbir Singh , KAMEZAWA Hiroyuki , linux-mm , Rik van Riel , Andrew Morton , LKML , Peter Zijlstra Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 30 On Wed, Aug 14, 2013 at 11:28 AM, Michal Hocko wrote: > > OK that would suggest the issue has been introduced by 597e1c35: > (mm/mmu_gather: enable tlb flush range in generic mmu_gather) in 3.6 > which is not 3.7 when Ben started seeing the issue but this definitely > smells like a bug that would be amplified by the bisected patch. Yes, the bug was originally introduced in 597e1c35, but in practice it never happened, because the force_flush case would not ever really trigger unless __get_free_pages(GFP_NOWAIT) returned NULL. Which is *very* rare. So the commit that Ben bisected things down to wasn't the one that really introduced the bug, but it was the one that made tlb_next_batch() much more likely to return failure, which in turn made it much easier to *expose* the bug. NOTE! I still absolutely want Ben to actually test that fix (ie backport commit e6c495a96ce0 to his tree), because without testing this is all just theoretical, and there might be other things hiding here. But it makes sense to me, and I think this already-known bug explains the symptoms. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/