Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933340Ab3HNXlM (ORCPT ); Wed, 14 Aug 2013 19:41:12 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:60989 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932373Ab3HNXlJ (ORCPT ); Wed, 14 Aug 2013 19:41:09 -0400 Message-ID: <520C156D.2090003@ti.com> Date: Wed, 14 Aug 2013 18:40:29 -0500 From: Joel Fernandes User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joe Perches CC: Herbert Xu , "David S. Miller" , Mark Greer , Tony Lindgren , Santosh Shilimkar , Rajendra Nayak , Lokesh Vutla , Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List , Linux Crypto Mailing List Subject: Re: [PATCH 02/10] crypto: omap-aes: Add useful debug macros References: <1376521969-16807-1-git-send-email-joelf@ti.com> <1376521969-16807-3-git-send-email-joelf@ti.com> <1376522998.1949.118.camel@joe-AO722> In-Reply-To: <1376522998.1949.118.camel@joe-AO722> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2411 Lines: 81 On 08/14/2013 06:29 PM, Joe Perches wrote: > On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote: >> When DEBUG is enabled, these macros can be used to print variables >> in integer and hex format, and clearly display which registers, >> offsets and values are being read/written , including printing the >> names of the offsets and their values. > [] >> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c > [] >> @@ -15,6 +15,14 @@ >> >> #define pr_fmt(fmt) "%s: " fmt, __func__ >> >> +#ifdef DEBUG >> +#define prn(num) printk(#num "=%d\n", num) >> +#define prx(num) printk(#num "=%x\n", num) > > pr_debug? Sure, can change that. >> +#else >> +#define prn(num) do { } while (0) >> +#define prx(num) do { } while (0) >> +#endif > [] >> @@ -172,13 +180,35 @@ struct omap_aes_dev { >> static LIST_HEAD(dev_list); >> static DEFINE_SPINLOCK(list_lock); >> >> +#ifdef DEBUG >> +#define omap_aes_read(dd, offset) \ >> + do { \ >> + omap_aes_read_1(dd, offset); \ >> + pr_debug("omap_aes_read(" #offset ")\n"); \ >> + } while (0) >> + >> +static inline u32 omap_aes_read_1(struct omap_aes_dev *dd, u32 offset) >> +#else >> static inline u32 omap_aes_read(struct omap_aes_dev *dd, u32 offset) >> +#endif >> { >> return __raw_readl(dd->io_base + offset); >> } >> >> +#ifdef DEBUG >> +#define omap_aes_write(dd, offset, value) \ >> + do { \ >> + pr_debug("omap_aes_write(" #offset "=%x) value=%d\n", \ >> + offset, value); \ >> + omap_aes_write_1(dd, offset, value); \ >> + } while (0) >> + >> +static inline void omap_aes_write_1(struct omap_aes_dev *dd, u32 offset, >> + u32 value) >> +#else >> static inline void omap_aes_write(struct omap_aes_dev *dd, u32 offset, >> u32 value) >> +#endif >> { >> __raw_writel(value, dd->io_base + offset); >> } > > Umm, yuck? > > Is there any real value in read_1 and write_1? Can you be more descriptive? There is a lot of value in them for debug to show clearly sequence of read/writes. Moreover, they are no-op'd when DEBUG is disabled. Other than the obvious use, I guess it could be rewritten to be bit cleaner. I can do that. -Joel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/