Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760196Ab3HODi7 (ORCPT ); Wed, 14 Aug 2013 23:38:59 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:21123 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759662Ab3HODi6 convert rfc822-to-8bit (ORCPT ); Wed, 14 Aug 2013 23:38:58 -0400 From: Caizhiyong To: Brian Norris , Andrew Morton CC: Karel Zak , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Wanglin (Albert)" , Artem Bityutskiy , Shmulik Ladkani , Huang Shijie Subject: RE: [PATCH] block: add command line partition parser Thread-Topic: [PATCH] block: add command line partition parser Thread-Index: AQHOl+qqJeZC0CvH906unOBo+NYxZJmUzWsAgAAUuICAAKUVMA== Date: Thu, 15 Aug 2013 03:38:47 +0000 Message-ID: References: <20130805152206.76462cc4a42e51b16a0532f1@linux-foundation.org> <20130814155742.d3cd651e40e552696667e4f2@linux-foundation.org> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.223.18] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3362 Lines: 77 > -----Original Message----- > From: Brian Norris [mailto:computersforpeace@gmail.com] > Sent: Thursday, August 15, 2013 8:12 AM > To: Andrew Morton > Cc: Caizhiyong; Karel Zak; linux-mtd@lists.infradead.org; > linux-kernel@vger.kernel.org; Wanglin (Albert); Artem Bityutskiy; Shmulik Ladkani; > Huang Shijie > Subject: Re: [PATCH] block: add command line partition parser > > On Wed, Aug 14, 2013 at 3:57 PM, Andrew Morton > wrote: > > On Tue, 13 Aug 2013 06:02:17 +0000 Caizhiyong wrote: > > > >> move the command line parser to a separate module, and change it into > >> library-style code. > >> > >> reference: https://lkml.org/lkml/2013/8/6/550 > > The most recent patch is an addendum to this linked patch then? > > > Well OK. But to prove the library's usefulness and to generally clean > > up the kernel, someone needs to sign up to the task of converting > > drivers/mtd/cmdlinepart.c to use this code. > > > > I've been hopefully cc'ing various MTD people but am not being > > overwhelmed with waves of enthusiasm ;) > > "I've been" implies that you have done so prior to this email. And > "people" implies more than one person. I see that you CC'd David > Woodhouse over a week ago, but he's fairly silent these days on MTD > things. It's Artem or me who handle most of the day-to-day of MTD. And > this is the first time I've seen this! (BTW, please include > linux-mtd@lists.infradead.org for anything involving MTD.) > > This seems reasonable, and I'd be willing to work with this proposal. > > Caizhiyong, can you submit a clear single patch (or series of > patches), CC'd to linux-mtd at least? Then we can see about supporting > it in MTD. It doesn't look too difficult, but I need to check that it > faithfully mimics the capability we currently rely on. There have been > previous discussions on changing it, but this was rejected in favor of > allowing more flexibility. Here's part of one such conversation: > > http://lists.infradead.org/pipermail/linux-mtd/2012-August/043599.html > http://lists.infradead.org/pipermail/linux-mtd/2012-September/043825.html > http://lists.infradead.org/pipermail/linux-mtd/2012-December/045322.html > > So I would recommend: > (1) consider carefully the implications of your command-line format > now, rather than later > (2) if you want MTD to use it, it needs to support the features we use now It is fully functional reference MTD, :-). > > Some particular cases to consider: overlapping partitions (how do > block devices handle overlapping partitions?), out-of-order > specification, zero sized partitions, mixed syntax (some specified > with an offset, some not), multiple '-' partitions. I think the 'offset' just is used to hide some MTD space. There are two way: 1) redefine the 'offset' as a gap between forward partition and next partition. 2) add code forbid command line partitions overlapping and out-of-order. I recommend 1), it seems to solve those problem(overlapping and out-of-order), but it will affect habit. > > Anyway, if you resend, we can review. > > Thanks, > Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/