Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760503Ab3HOHZr (ORCPT ); Thu, 15 Aug 2013 03:25:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43706 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753726Ab3HOHZp convert rfc822-to-8bit (ORCPT ); Thu, 15 Aug 2013 03:25:45 -0400 Subject: Re: [PATCH 03/10] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Alexander Graf In-Reply-To: <552A034A-CD3F-4737-B08A-E892E6420B83@suse.de> Date: Thu, 15 Aug 2013 09:25:40 +0200 Cc: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <836F3C3A-0031-4A16-B0CE-E6C1BA4925E4@suse.de> References: <1375332272-22176-1-git-send-email-aik@ozlabs.ru> <1375332272-22176-4-git-send-email-aik@ozlabs.ru> <520C81BE.70002@ozlabs.ru> <552A034A-CD3F-4737-B08A-E892E6420B83@suse.de> To: Alexey Kardashevskiy X-Mailer: Apple Mail (2.1278) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2227 Lines: 71 On 15.08.2013, at 09:24, Alexander Graf wrote: > > On 15.08.2013, at 09:22, Alexey Kardashevskiy wrote: > >> On 08/15/2013 05:16 PM, Alexander Graf wrote: >>> >>> On 01.08.2013, at 06:44, Alexey Kardashevskiy wrote: >>> >>>> This is to reserve a capablity number for upcoming support >>>> of VFIO-IOMMU DMA operations in real mode. >>>> >>>> Signed-off-by: Alexey Kardashevskiy >>>> >>>> --- >>>> Changes: >>>> 2013/07/16: >>>> * changed the number >>>> >>>> 2013/07/11: >>>> * changed order in a file, added comment about a gap in ioctl number >>>> >>>> Signed-off-by: Alexey Kardashevskiy >>>> --- >>>> include/uapi/linux/kvm.h | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >>>> index 99c2533..53c3f1f 100644 >>>> --- a/include/uapi/linux/kvm.h >>>> +++ b/include/uapi/linux/kvm.h >>>> @@ -668,6 +668,7 @@ struct kvm_ppc_smmu_info { >>>> #define KVM_CAP_IRQ_XICS 92 >>>> #define KVM_CAP_ARM_EL1_32BIT 93 >>>> #define KVM_CAP_SPAPR_MULTITCE 94 >>>> +#define KVM_CAP_SPAPR_TCE_IOMMU 95 >>>> >>>> #ifdef KVM_CAP_IRQ_ROUTING >>>> >>>> @@ -933,6 +934,9 @@ struct kvm_s390_ucas_mapping { >>>> #define KVM_ARM_SET_DEVICE_ADDR _IOW(KVMIO, 0xab, struct kvm_arm_device_addr) >>>> /* Available with KVM_CAP_PPC_RTAS */ >>>> #define KVM_PPC_RTAS_DEFINE_TOKEN _IOW(KVMIO, 0xac, struct kvm_rtas_token_args) >>>> +/* 0xad and 0xaf are already taken */ >>> >>> so 0xad and 0xaf are already taken? where? >> >> Mistype :( s/af/ae/ >> >> They are taken in this file: >> >> 1016 /* VM is being stopped by host */ >> 1017 #define KVM_KVMCLOCK_CTRL _IO(KVMIO, 0xad) >> 1018 #define KVM_ARM_VCPU_INIT _IOW(KVMIO, 0xae, struct kvm_vcpu_init) > > Could you please make sure that whoever reads the comment in a year still knows where to look? :) Something like /* 0xad is taken by KVM_KVMCLOCK_CTRL */ /* 0xaf is taken by KVM_ARM_VCPU_INIT */ Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/