Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755956Ab3HOLOp (ORCPT ); Thu, 15 Aug 2013 07:14:45 -0400 Received: from merlin.infradead.org ([205.233.59.134]:50431 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754566Ab3HOLOo (ORCPT ); Thu, 15 Aug 2013 07:14:44 -0400 Date: Thu, 15 Aug 2013 13:14:28 +0200 From: Peter Zijlstra To: Joonsoo Kim Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Mike Galbraith , Paul Turner , Alex Shi , Preeti U Murthy , Vincent Guittot , Morten Rasmussen , Namhyung Kim , Joonsoo Kim Subject: Re: [PATCH v3 3/3] sched: clean-up struct sd_lb_stat Message-ID: <20130815111428.GP24092@twins.programming.kicks-ass.net> References: <1375778203-31343-1-git-send-email-iamjoonsoo.kim@lge.com> <1375778203-31343-4-git-send-email-iamjoonsoo.kim@lge.com> <20130815110905.GO24092@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130815110905.GO24092@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 34 Another little diff. --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4647,8 +4647,10 @@ static inline void update_sd_lb_stats(st int local_group; local_group = cpumask_test_cpu(env->dst_cpu, sched_group_cpus(sg)); - if (local_group) + if (local_group) { + sds->this = sg; sgs = &sds->this_stat; + } memset(sgs, 0, sizeof(*sgs)); update_sg_lb_stats(env, sg, load_idx, local_group, sgs); @@ -4671,9 +4673,7 @@ static inline void update_sd_lb_stats(st sds->total_load += sgs->group_load; sds->total_pwr += sg->sgp->power; - if (local_group) - sds->this = sg; - else if (update_sd_pick_busiest(env, sds, sg, sgs)) { + if (!local_group && update_sd_pick_busiest(env, sds, sg, sgs)) { sds->busiest = sg; sds->busiest_stat = *sgs; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/