Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625Ab3HPHJV (ORCPT ); Fri, 16 Aug 2013 03:09:21 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:9610 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751647Ab3HPHIQ (ORCPT ); Fri, 16 Aug 2013 03:08:16 -0400 X-IronPort-AV: E=Sophos;i="4.89,892,1367942400"; d="scan'208";a="8217638" From: Tang Chen To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, lenb@kernel.org, rjw@sisk.pl, liwanp@linux.vnet.ibm.com, tj@kernel.org, akpm@linux-foundation.org Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH 1/6] acpi, numa, mem_hotplug: Kill save_add_info(). Date: Fri, 16 Aug 2013 15:06:44 +0800 Message-Id: <1376636809-10159-2-git-send-email-tangchen@cn.fujitsu.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1376636809-10159-1-git-send-email-tangchen@cn.fujitsu.com> References: <1376636809-10159-1-git-send-email-tangchen@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/16 15:06:32, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/16 15:06:36, Serialize complete at 2013/08/16 15:06:36 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2512 Lines: 80 save_add_info() is defined as: #ifdef CONFIG_MEMORY_HOTPLUG static inline int save_add_info(void) {return 1;} #else static inline int save_add_info(void) {return 0;} #endif which means it is true when memory hotplug is configured. In acpi_numa_memory_affinity_init(), it checks the memory hotplug flag in SRAT memory affinity and save_add_info() like this: if ((ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) && !save_add_info()) goto out_err; ...... node = setup_node(pxm); numa_add_memblk(node, start, end); ...... which means if the memory range is hotpluggable, but memory hotplug is not configured, it won't add these memory to numa_meminfo. After this, numa_meminfo_cover_memory() will fail, which will finally cause numa_init() to fail. numa_init() |->numa_register_memblks() |->numa_meminfo_cover_memory() When numa_init() fails, it will fallback to numa_init(dummy_numa_init), and all numa architecture will not be setup. This is nonsense. Even if memory hotplug is not configured, we can also use numa architecture. Actually, save_add_info() is added by commit 71efa8fdc55e70ec6687c897a30759f0a2c2ad7e in 2006. And now it is useless. So this patch kill save_add_info() and the nonsense checking. Signed-off-by: Tang Chen --- arch/x86/mm/srat.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c index cdd0da9..1613c02 100644 --- a/arch/x86/mm/srat.c +++ b/arch/x86/mm/srat.c @@ -135,12 +135,6 @@ acpi_numa_processor_affinity_init(struct acpi_srat_cpu_affinity *pa) pxm, apic_id, node); } -#ifdef CONFIG_MEMORY_HOTPLUG -static inline int save_add_info(void) {return 1;} -#else -static inline int save_add_info(void) {return 0;} -#endif - /* Callback for parsing of the Proximity Domain <-> Memory Area mappings */ int __init acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma) @@ -154,8 +148,6 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma) goto out_err_bad_srat; if ((ma->flags & ACPI_SRAT_MEM_ENABLED) == 0) goto out_err; - if ((ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) && !save_add_info()) - goto out_err; start = ma->base_address; end = start + ma->length; -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/