Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239Ab3HPIAE (ORCPT ); Fri, 16 Aug 2013 04:00:04 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:34477 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737Ab3HPH77 (ORCPT ); Fri, 16 Aug 2013 03:59:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <333bf5868dfbfb6de474f060dc216fa6d33848e2.1376619363.git.viresh.kumar@linaro.org> Date: Fri, 16 Aug 2013 13:29:58 +0530 Message-ID: Subject: Re: [PATCH 02/34] cpufreq: acpi: remove calls to cpufreq_notify_transition() From: Viresh Kumar To: Lan Tianyu Cc: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , Linux PM list , "linux-kernel@vger kernel org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 27 On 16 August 2013 13:24, Lan Tianyu wrote: > Sorry for misoperation. No Problem... > One concern. Target() callback may return before changing > cpufreq actually due to some check failures. After this change, prechange > event will be triggered when these check failures take place. I am not sure > whether this should be took into account. Yes, if you see the first patch of this series, it takes this into account.. In case target() failed and returned an error, we simply notify the POST CHANGE notification with old frequencies instead of new ones. I believe that would be enough.. This is exactly what acpi-cpufreq and others are doing currently. Hope I answered your question well? -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/