DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Reply-To:Subject:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=2ZOVwKNP3cEO+PabPp8nvGM6iIWvIZ4ZwndntVhHEWE8yuxyQimBulbYQVzSwUDSFKYZCHqMgHUpmUd1OBd41GMHKyZqKrlMSOsgx0x0O1HpLugy2x/lvl5WxhYis8/ZojyePaTGABFXdtktdI+5ktnPfRfgKLgETxhH7EK7G8c=;
Message-ID: <1376643218.59144.YahooMailNeo@web160103.mail.bf1.yahoo.com>
Date: Fri, 16 Aug 2013 01:53:38 -0700 (PDT)
From: Alban Browaeys <prahal@yahoo.com>
Reply-To: Alban Browaeys <prahal@yahoo.com>
Subject: usb: misc: usb3503: connect and intn mismatch in OF vs variable assignments
To: Dongjin Kim <tobetter@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>,
        Rob Herring <rob.herring@calxeda.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 790
Lines: 20

hub->gpio_intn? = of_get_named_gpio(np, "connect-gpios", 0);
and
hub->gpio_connect = of_get_named_gpio(np, "intn-gpios", 0);

I guess they should be switched , that is connect-gpios bound to hub->gpio_connect
and intn-gpios to hub->gpio_int.

Sorry not to provides a patch. I thought that this issue might ends up with dts relying
on this broken behaviour if not pointed early ...
Either way if not fixed soon , I will have completed my branch cleanup (I also have other patches
to this file ie drivers/usb/misc/usb3503.c).

Best regards
Alban

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/