Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755295Ab3HPJqB (ORCPT ); Fri, 16 Aug 2013 05:46:01 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:35734 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754904Ab3HPJp5 (ORCPT ); Fri, 16 Aug 2013 05:45:57 -0400 MIME-Version: 1.0 In-Reply-To: <1376643218.59144.YahooMailNeo@web160103.mail.bf1.yahoo.com> References: <1376643218.59144.YahooMailNeo@web160103.mail.bf1.yahoo.com> Date: Fri, 16 Aug 2013 18:45:56 +0900 Message-ID: Subject: Re: usb: misc: usb3503: connect and intn mismatch in OF vs variable assignments From: Dongjin Kim To: Alban Browaeys Cc: Grant Likely , Rob Herring , Greg Kroah-Hartman , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 30 Hi, The patch is submitted by Mark Brown a week ago, and might be queued already. [1] http://www.spinics.net/lists/linux-usb/msg91410.html Thanks, Dongjin. On Fri, Aug 16, 2013 at 5:53 PM, Alban Browaeys wrote: > hub->gpio_intn = of_get_named_gpio(np, "connect-gpios", 0); > and > hub->gpio_connect = of_get_named_gpio(np, "intn-gpios", 0); > > I guess they should be switched , that is connect-gpios bound to hub->gpio_connect > and intn-gpios to hub->gpio_int. > > Sorry not to provides a patch. I thought that this issue might ends up with dts relying > on this broken behaviour if not pointed early ... > Either way if not fixed soon , I will have completed my branch cleanup (I also have other patches > to this file ie drivers/usb/misc/usb3503.c). > > Best regards > Alban > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/