Date: Fri, 16 Aug 2013 20:17:49 +0900
From: Cho KyongHo <pullip.cho@samsung.com>
To: "'Joerg Roedel'" <joro@8bytes.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>, Tomasz Figa <t.figa@samsung.com>,
        "'Linux ARM Kernel'" <linux-arm-kernel@lists.infradead.org>,
        "'Linux IOMMU'" <iommu@lists.linux-foundation.org>,
        "'Linux Kernel'" <linux-kernel@vger.kernel.org>,
        "'Linux Samsung SOC'" <linux-samsung-soc@vger.kernel.org>,
        devicetree@vger.kernel.org, "'Kukjin Kim'" <kgene.kim@samsung.com>,
        "'Prathyush'" <prathyush.k@samsung.com>,
        "'Rahul Sharma'" <rahul.sharma@samsung.com>,
        "'Subash Patel'" <supash.ramaswamy@linaro.org>,
        "'Grant Grundler'" <grundler@chromium.org>,
        "'Antonios Motakis'" <a.motakis@virtualopensystems.com>,
        kvmarm@lists.cs.columbia.edu,
        "'Sachin Kamat'" <sachin.kamat@linaro.org>
Subject: Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own
 slab
Message-id: <20130816201749.a4bbaa8e85fc5a2d4e0b02ad@samsung.com>
In-reply-to: <20130814105615.GG4491@8bytes.org>
References: <002801ce941a$fb6369e0$f22a3da0$@samsung.com>
 <2544843.sndV7usHTj@amdc1227>
 <20130809145849.790a9800f4f9893b30e54a1c@samsung.com>
 <2101296.S6JDU5igl3@flatron> <20130814105615.GG4491@8bytes.org>
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 824
Lines: 24

On Wed, 14 Aug 2013 12:56:16 +0200, 'Joerg Roedel' wrote:
> On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote:
> > Oh, this is a valid point, but it was more a nitpick about the coding 
> > style. Single path error handling (with goto) is widely used in the kernel 
> > in cases when more than one thing has to be undone and so I suggested this 
> > method of error handling here as well.
> 
> I agree with that review from Tomasz, the error-handling should look
> similar to all the other places in the kernel and use goto.
> 
Ok.

Thanks.

KyongHo.
> 
> 	Joerg
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/