Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013Ab3HPNes (ORCPT ); Fri, 16 Aug 2013 09:34:48 -0400 Received: from mail-oa0-f52.google.com ([209.85.219.52]:47206 "EHLO mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933Ab3HPNeq (ORCPT ); Fri, 16 Aug 2013 09:34:46 -0400 MIME-Version: 1.0 In-Reply-To: <1375304231-27281-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1375304231-27281-1-git-send-email-vivien.didelot@savoirfairelinux.com> Date: Fri, 16 Aug 2013 15:34:45 +0200 Message-ID: Subject: Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/ From: Linus Walleij To: Vivien Didelot Cc: "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , kernel@savoirfairelinux.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 38 On Wed, Jul 31, 2013 at 10:57 PM, Vivien Didelot wrote: > This patch moves the pca953x.h header from include/linux/i2c to > include/linux/platform_data and updates existing support accordingly. > > Signed-off-by: Vivien Didelot On the concept: Acked-by: Linus Walleij But: > drivers/gpio/gpio-pca953x.c | 2 +- (...) > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index 426c51d..8804aec 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -18,7 +18,7 @@ > #include > #include > #include > -#include > +#include Why does the GPIO driver need platform data from the I2C driver??? Can't this just be made to go away? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/