Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754457Ab3HPNre (ORCPT ); Fri, 16 Aug 2013 09:47:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51440 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754289Ab3HPNrb (ORCPT ); Fri, 16 Aug 2013 09:47:31 -0400 Date: Fri, 16 Aug 2013 06:49:07 -0700 From: Greg Kroah-Hartman To: Enrico Mioso Cc: =?iso-8859-1?Q?Bj=F8rn?= Mork , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use Message-ID: <20130816134907.GA10987@kroah.com> References: <87wqp9xja5.fsf@nemi.mork.no> <0cbf7c81-182e-493c-9c28-5b78160a08f1@email.android.com> <87bo4xx3ef.fsf@nemi.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 19 On Fri, Aug 16, 2013 at 03:39:19PM +0200, Enrico Mioso wrote: > Some drivers implementing NCM-like protocols, may re-use those functions, as is > the case in the huawei_cdc_ncm driver. Where is that driver at, I don't see it in the kernel tree. > Export them via EXPORT_SYMBOL_GPL. Normally we don't export symbols until code that actually uses the symbols lands in the tree at the same time. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/