Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853Ab3HPNuw (ORCPT ); Fri, 16 Aug 2013 09:50:52 -0400 Received: from mail-ee0-f54.google.com ([74.125.83.54]:54449 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754735Ab3HPNuo (ORCPT ); Fri, 16 Aug 2013 09:50:44 -0400 Date: Fri, 16 Aug 2013 15:51:10 +0200 (CEST) From: Enrico Mioso X-X-Sender: mrkiko@eeeadesso To: Greg Kroah-Hartman cc: Enrico Mioso , =?ISO-8859-15?Q?Bj=F8rn_Mork?= , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use In-Reply-To: <20130816134907.GA10987@kroah.com> Message-ID: References: <87wqp9xja5.fsf@nemi.mork.no> <0cbf7c81-182e-493c-9c28-5b78160a08f1@email.android.com> <87bo4xx3ef.fsf@nemi.mork.no> <20130816134907.GA10987@kroah.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 37 Yes, you're right. I'm sorry - this time I didn't apply numbering scheme to those 3 patches - yet they are consequential, but not depending on each other from a strict point of view. Thank you for your review Greg! On Fri, 16 Aug 2013, Greg Kroah-Hartman wrote: ==Date: Fri, 16 Aug 2013 06:49:07 -0700 ==From: Greg Kroah-Hartman ==To: Enrico Mioso ==Cc: Bj?rn Mork , linux-kernel@vger.kernel.org, == linux-usb@vger.kernel.org, netdev@vger.kernel.org ==Subject: Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx, == rx}_fixup functions for re-use == ==On Fri, Aug 16, 2013 at 03:39:19PM +0200, Enrico Mioso wrote: ==> Some drivers implementing NCM-like protocols, may re-use those functions, as is ==> the case in the huawei_cdc_ncm driver. == ==Where is that driver at, I don't see it in the kernel tree. == ==> Export them via EXPORT_SYMBOL_GPL. == ==Normally we don't export symbols until code that actually uses the ==symbols lands in the tree at the same time. == ==thanks, == ==greg k-h == -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/