Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754717Ab3HPPCY (ORCPT ); Fri, 16 Aug 2013 11:02:24 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:54654 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375Ab3HPPCV (ORCPT ); Fri, 16 Aug 2013 11:02:21 -0400 Date: Fri, 16 Aug 2013 11:02:20 -0400 (EDT) From: Vivien Didelot To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Message-ID: <82440653.410050.1376665340121.JavaMail.root@mail> In-Reply-To: Subject: Re: [PATCH] gpio: (gpio-pca953x) move header to linux/platform_data/ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 7.1.4_GA_2555 (ZimbraWebClient - GC28 (Linux)/7.1.4_GA_2555) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 36 Hi Linus, You wrote: > But: > > > drivers/gpio/gpio-pca953x.c | 2 +- > (...) > > diff --git a/drivers/gpio/gpio-pca953x.c > > b/drivers/gpio/gpio-pca953x.c > > index 426c51d..8804aec 100644 > > --- a/drivers/gpio/gpio-pca953x.c > > +++ b/drivers/gpio/gpio-pca953x.c > > @@ -18,7 +18,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > Why does the GPIO driver need platform data from the > I2C driver??? > > Can't this just be made to go away? I didn't dig that much in the driver, but I cannot imagine another way to pass, for instance, the setup callback. What would be a good alternative for you? Regards, Vivien -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/