Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754753Ab3HPPJJ (ORCPT ); Fri, 16 Aug 2013 11:09:09 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:53580 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754644Ab3HPPJF convert rfc822-to-8bit (ORCPT ); Fri, 16 Aug 2013 11:09:05 -0400 MIME-Version: 1.0 In-Reply-To: <20130809173326.75aed3b6@mail.gmx.de> References: <20130809173326.75aed3b6@mail.gmx.de> Date: Fri, 16 Aug 2013 17:09:04 +0200 Message-ID: Subject: Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver From: Linus Walleij To: Michael Brunner Cc: "linux-kernel@vger.kernel.org" , Guenter Roeck , Kevin Strasser , Darren Hart , Samuel Ortiz , Chris Healy , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 43 On Fri, Aug 9, 2013 at 5:33 PM, Michael Brunner wrote: > This patch fixes the bit masking within the GPIO driver. The masking is > basically done twice which causes the wrong GPIOs to be addressed. > > Signed-off-by: Michael Brunner This looks good but just doesn't apply. Look: git am --signoff brunner2.patch Till?mpar: gpio: Fix bit masking in Kontron PLD GPIO driver error: patch misslyckades: drivers/gpio/gpio-kempld.c:46 error: drivers/gpio/gpio-kempld.c: patchen kan inte till?mpas Then: patch -p1 < brunner2.patch patching file drivers/gpio/gpio-kempld.c Hunk #1 FAILED at 46. Hunk #2 FAILED at 60. Hunk #3 FAILED at 69. Hunk #4 FAILED at 80. Hunk #5 FAILED at 92. Hunk #6 FAILED at 107. Hunk #7 FAILED at 122. 7 out of 7 hunks FAILED -- saving rejects to file drivers/gpio/gpio-kempld.c.rej I think there may be some whitespace mangling in your client or mail server or whatever. I had the same problem with the previous patch but hand-coded it right since it was just a oneline. Please try to figure out what is causing this. Consult: Documentation/email-clients.txt Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/