Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982Ab3HPPbE (ORCPT ); Fri, 16 Aug 2013 11:31:04 -0400 Received: from mail-qa0-f42.google.com ([209.85.216.42]:49134 "EHLO mail-qa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527Ab3HPPa5 (ORCPT ); Fri, 16 Aug 2013 11:30:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <333bf5868dfbfb6de474f060dc216fa6d33848e2.1376619363.git.viresh.kumar@linaro.org> Date: Fri, 16 Aug 2013 23:30:56 +0800 Message-ID: Subject: Re: [PATCH 02/34] cpufreq: acpi: remove calls to cpufreq_notify_transition() From: Lan Tianyu To: Viresh Kumar Cc: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , Linux PM list , "linux-kernel@vger kernel org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 45 2013/8/16 Viresh Kumar : > On 16 August 2013 13:24, Lan Tianyu wrote: >> Sorry for misoperation. > > No Problem... > >> One concern. Target() callback may return before changing >> cpufreq actually due to some check failures. After this change, prechange >> event will be triggered when these check failures take place. I am not sure >> whether this should be took into account. > > Yes, if you see the first patch of this series, it takes this into > account.. In case > target() failed and returned an error, we simply notify the POST CHANGE > notification with old frequencies instead of new ones. I believe that would be > enough.. Yes, I have seen it but I missed the following two patches because they are not in the linux-pm tree. You moved the cpufreq_frequency_table_target() to cpufreq core and before notifying PRE CHANGE notification. The major check has been done. Now I think it's ok. Thanks for explanation. http://www.spinics.net/lists/cpufreq/msg06970.html http://www.spinics.net/lists/cpufreq/msg06896.html Reviewed-by: Lan Tianyu > > This is exactly what acpi-cpufreq and others are doing currently. > > Hope I answered your question well? > > -- > viresh -- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/