Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754741Ab3HPRiR (ORCPT ); Fri, 16 Aug 2013 13:38:17 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:59798 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824Ab3HPRiN (ORCPT ); Fri, 16 Aug 2013 13:38:13 -0400 MIME-Version: 1.0 In-Reply-To: <20130816173000.GA8210@xanatos> References: <71bb3fcd9f1a99aa7bd8f6dd1fb6267173db51d2.1376582695.git.d.kasatkin@samsung.com> <70b3564625bbda6247cc5627041344fef8a762ae.1376582695.git.d.kasatkin@samsung.com> <20130816001716.GA7367@kroah.com> <20130816172635.GA7975@xanatos> <20130816173000.GA8210@xanatos> Date: Fri, 16 Aug 2013 20:38:12 +0300 Message-ID: Subject: Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled From: Dmitry Kasatkin To: Sarah Sharp Cc: Sarah Sharp , Greg KH , Dmitry Kasatkin , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2827 Lines: 65 On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp wrote: > On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: >> On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote: >> > On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: >> > > When debug is not enabled and dev_dbg() will expand to nothing, >> > > log might be flooded with "callbacks suppressed". If it was not >> > > done on purpose, better to use dev_dbg_ratelimited() instead. >> > > >> > > Signed-off-by: Dmitry Kasatkin >> > > --- >> > > drivers/usb/host/xhci-ring.c | 6 ++---- >> > > 1 file changed, 2 insertions(+), 4 deletions(-) >> > >> > >> > Sarah, does this patch conflict with the trace debug patches being >> > worked on? I'll hold off on applying it for now, let me know if it's ok >> > or not. >> >> It doesn't conflict with the trace debug patches, because those only >> effect debugging with xhci_dbg with the host device, not dev_dbg with >> the USB device. This should apply fine to usb-next. > > At another glance, the patch removes two if blocks, but doesn't > re-indent the rest of the lines: > >> @@ -3060,8 +3060,7 @@ int xhci_queue_intr_tx(struct xhci_hcd *xhci, gfp_t mem_flags, >> * to set the polling interval (once the API is added). >> */ >> if (xhci_interval != ep_interval) { >> - if (printk_ratelimit()) >> - dev_dbg(&urb->dev->dev, "Driver uses different interval" >> + dev_dbg_ratelimited(&urb->dev->dev, "Driver uses different interval" >> " (%d microframe%s) than xHCI " >> "(%d microframe%s)\n", >> ep_interval, > > That should probably be fixed. It actually looks correct when patch is applied. But it depends what you mean of course. It looks like it was before: dev_dbg_ratelimited(&urb->dev->dev, "Driver uses different interval" " (%d microframe%s) than xHCI " "(%d microframe%s)\n", ep_interval, ep_interval == 1 ? "" : "s", Or may be you mean: dev_dbg_ratelimited(&urb->dev->dev, "Driver uses different interval" " (%d microframe%s) than xHCI " "(%d microframe%s)\n", ep_interval, ep_interval == 1 ? "" : "s", Thanks, Dmitry > > Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/