Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754947Ab3HPRjy (ORCPT ); Fri, 16 Aug 2013 13:39:54 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:37710 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765Ab3HPRju (ORCPT ); Fri, 16 Aug 2013 13:39:50 -0400 Message-ID: <1376675180.5171.238.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing From: "Nicholas A. Bellinger" To: Alexander Gordeev Cc: Mike Christie , James Bottomley , Jens Axboe , Tejun Heo , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Jeff Garzik , linux-scsi Date: Fri, 16 Aug 2013 10:46:20 -0700 In-Reply-To: <20130816164156.GA14582@dhcp-26-207.brq.redhat.com> References: <1374195825.7397.997.camel@haakon3.risingtidesystems.com> <1374215660.7397.1041.camel@haakon3.risingtidesystems.com> <1374248000.2266.20.camel@dabdike> <1374267684.7397.1058.camel@haakon3.risingtidesystems.com> <1374296162.7397.1098.camel@haakon3.risingtidesystems.com> <51EAA33C.9010405@fusionio.com> <20130809191542.GD25306@dhcp-26-207.brq.redhat.com> <1376079457.5171.172.camel@haakon3.risingtidesystems.com> <20130815162316.GA27882@dhcp-26-207.brq.redhat.com> <1376619569.5171.217.camel@haakon3.risingtidesystems.com> <20130816164156.GA14582@dhcp-26-207.brq.redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 28 On Fri, 2013-08-16 at 18:41 +0200, Alexander Gordeev wrote: > On Thu, Aug 15, 2013 at 07:19:29PM -0700, Nicholas A. Bellinger wrote: > > I'm playing with a patch to do this, but am currently getting hung-up on > > what appear to be some separate blk-mq reserved_tags > 0 bugs, the first > > of which is passing queue_depth=1 + reserved_tags=1 is broken, and > > results in tags->nr_free = 0. > > That is not a bug - please look at Jens replies in this thread some week ago. > In short, queue_depth=1 means 1 tags in total and reserved_tags=1 results > in zero normal tags. You need to request the depth=2 and reserved_tags=1. > Ahhh, yes of course. I'll re-work a proposed patch this afternoon with this in mind.. > But yes, this is a separate topic and I am looking forward to hear from Jens > wrt flushes. > Indeed. ;) --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/