Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754520Ab3HPSCu (ORCPT ); Fri, 16 Aug 2013 14:02:50 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:62553 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754147Ab3HPSCq (ORCPT ); Fri, 16 Aug 2013 14:02:46 -0400 Date: Fri, 16 Aug 2013 20:02:40 +0200 From: "Yann E. MORIN" To: Sam Ravnborg Cc: Michal Marek , Stephen Rothwell , Steven Rostedt , Kevin Hilman , sedat.dilek@gmail.com, "Theodore Ts'o" , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Linux kbuild ML Subject: Re: linux-next: build failure after merge of the ext4 tree Message-ID: <20130816180240.GA2715@free.fr> References: <20130807153840.4f2997b603397c07aca98b2d@canb.auug.org.au> <87zjsted0c.fsf@linaro.org> <20130808102228.d2034d3a4c986d2970926ab9@canb.auug.org.au> <20130808103614.a039da2f236154b52329b28b@canb.auug.org.au> <20130808191650.GB3282@free.fr> <20130808215449.GD3282@free.fr> <20130809114248.GA5691@merkur.ravnborg.org> <20130811213923.GA5312@free.fr> <520E24CE.9040604@suse.cz> <20130816171448.GA13841@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130816171448.GA13841@merkur.ravnborg.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2817 Lines: 64 Sam, Michal, All, On 2013-08-16 19:14 +0200, Sam Ravnborg spake thusly: > On Fri, Aug 16, 2013 at 03:10:38PM +0200, Michal Marek wrote: > > On 11.8.2013 23:39, Yann E. MORIN wrote: > > > On 2013-08-09 13:42 +0200, Sam Ravnborg spake thusly: > > >> If we drop the special handling of "MODULES" and introduced > > >> the following in we may fix it - hopefully: > > >> > > >> config MODULES > > >> option modules > > >> > > >> The option handling is already in place. It is even documented :-) > > > > > > Yes, indeed, that one is pretty easy! :-) > > > > > >> At least we could then drop the sym_lookup here (zconf.y): > > >> if (!modules_sym->prop) { > > >> struct property *prop; > > >> > > >> prop = prop_alloc(P_DEFAULT, modules_sym); > > >> prop->expr = expr_alloc_symbol(sym_lookup("MODULES", 0)); > > >> } > > >> Without the sym_lookup I think the symbol will not be defined and tus not marked valid. > > > > > > Sorry, I don't understand what we should do here. > > > > > > From what I understand, here's what happens: > > > - there's no symbol that declared the 'modules' option, so the > > > modules_sym->prop is NULL; > > > - so we look for the symbol 'MODULES' and use that as the symbol used > > > to evaluate if tristates are enabled. > > > > > > So, now we have 'option modules' added to MODULES, we never enter this > > > if() condition. > > > > > > But what would happen to other projects that do not have a symbol set > > > with 'option modules' and no 'MODULES' symbol? Surely, those projects do > > > not need tristates, but what should the code do in this case? > > > > > > So, I don't know what to replace this 'sym_lookup("MODULES", 0)' with. > > > > If the Kconfig files do not provide any symbol with 'option modules', > > then set modules_sym to a dummy bool with the value 'n'? > This is my thinking too - to use the symbol "n". > But I wanted to try it out - but so far have not had time for it. OK, I'll tackle this. Thanks for the info. :-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/