Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754392Ab3HPSqJ (ORCPT ); Fri, 16 Aug 2013 14:46:09 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:36356 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439Ab3HPSqH (ORCPT ); Fri, 16 Aug 2013 14:46:07 -0400 Message-ID: <520E7377.1080808@cogentembedded.com> Date: Fri, 16 Aug 2013 22:46:15 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "Lad, Prabhakar" CC: Sekhar Nori , DLOS , netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, LKML , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet References: <1376662262-21795-1-git-send-email-prabhakar.csengg@gmail.com> <1376662262-21795-2-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1376662262-21795-2-git-send-email-prabhakar.csengg@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 55 Hello. On 08/16/2013 06:11 PM, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > Add ethernet device tree node information and pinmux for mii to da850 by > providing interrupt details and local mac address. > Signed-off-by: Lad, Prabhakar > --- > arch/arm/boot/dts/da850-evm.dts | 5 +++++ > arch/arm/boot/dts/da850.dtsi | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 35 insertions(+) > diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts > index 1f8cfdd..44f3fbc 100644 > --- a/arch/arm/boot/dts/da850-evm.dts > +++ b/arch/arm/boot/dts/da850-evm.dts > @@ -96,6 +96,11 @@ > pinctrl-0 = <&mdio_pins>; > bus_freq = <2200000>; > }; > + ethernet: emac@1e20000 { Why label the node in the board file too? > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mii_pins>; > + }; > }; > nand_cs3@62000000 { > status = "okay"; > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index d5138b4..a5d30d9 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi [...] > @@ -226,6 +242,20 @@ > #size-cells = <0>; > reg = <0x224000 0x1000>; > }; > + ethernet: emac@1e20000 { I said node should be named "ethernet", not labelled. You're the second person that doesn't know the difference between the two. :-) WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/