Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754935Ab3HQW5v (ORCPT ); Sat, 17 Aug 2013 18:57:51 -0400 Received: from mail-oa0-f53.google.com ([209.85.219.53]:38936 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754866Ab3HQW5u (ORCPT ); Sat, 17 Aug 2013 18:57:50 -0400 MIME-Version: 1.0 In-Reply-To: <20130817152853.GA24838@amd.pavel.ucw.cz> References: <51F1B015.50804@hurleysoftware.com> <20130730124117.41DC55E4006@freak.gnuservers.com.ar> <51F7E4ED.4050409@hurleysoftware.com> <20130808175839.GB21618@gnuservers.com.ar> <20130817152853.GA24838@amd.pavel.ucw.cz> Date: Sun, 18 Aug 2013 00:57:50 +0200 Message-ID: Subject: Re: Large pastes into readline enabled programs causes breakage from v2.6.31 onwards From: Margarita Manterola To: Pavel Machek Cc: Maximiliano Curia , Peter Hurley , Greg Kroah-Hartman , Jiri Slaby , Linux kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 34 Hi, On Sat, Aug 17, 2013 at 5:28 PM, Pavel Machek wrote: >> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c >> index 4bf0fc0..2ba7f4e 100644 >> --- a/drivers/tty/n_tty.c >> +++ b/drivers/tty/n_tty.c >> @@ -149,7 +149,8 @@ static int set_room(struct tty_struct *tty) >> * characters will be beeped. >> */ >> if (left <= 0) >> - left = ldata->icanon && !ldata->canon_data; >> + if (waitqueue_active(&tty->read_wait)) >> + left = ldata->icanon && !ldata->canon_data; >> old_left = tty->receive_room; >> tty->receive_room = left; > Was this applied? You may want to cc rjw... it is a regression, it is > not pretty, and it is something I blieve I hit but thought it was some > kind of "X weirdness". There were no replies to the previous mail asking for comments, and as far as I can see this has not been applied. I don't know who rjw is, could you be a bit more explicit, please? -- Besos, Marga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/