Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755199Ab3HRKAy (ORCPT ); Sun, 18 Aug 2013 06:00:54 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:35236 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754165Ab3HRKAw (ORCPT ); Sun, 18 Aug 2013 06:00:52 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Sun, 18 Aug 2013 15:30:50 +0530 X-Google-Sender-Auth: jscCZz6angd-O6-Cu6idOPjylS4 Message-ID: Subject: Re: [PATCH 03/44] cpufreq: exynos: call cpufreq_frequency_table_put_attr() From: amit daniel kachhap To: Viresh Kumar Cc: "Rafael J. Wysocki" , linaro-kernel@lists.linaro.org, "patches@linaro.org" , cpufreq@vger.kernel.org, "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kukjin Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3540 Lines: 97 On Sat, Aug 10, 2013 at 12:13 PM, Viresh Kumar wrote: > Drivers which have an exit path must call cpufreq_frequency_table_put_attr() if > they have called cpufreq_frequency_table_get_attr() in their init path. > > This driver was missing this part and is fixed with this patch. > > Cc: Kukjin Kim > Signed-off-by: Viresh Kumar The changes looks fine, please free to add Acked-By: Amit Daniel Kachhap Thanks. Amit Daniel > --- > drivers/cpufreq/exynos5440-cpufreq.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c > index 1ac93e0..b9dfc91 100644 > --- a/drivers/cpufreq/exynos5440-cpufreq.c > +++ b/drivers/cpufreq/exynos5440-cpufreq.c > @@ -336,12 +336,18 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > return 0; > } > > +static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > +{ > + cpufreq_frequency_table_put_attr(policy->cpu); > +} > + > static struct cpufreq_driver exynos_driver = { > .flags = CPUFREQ_STICKY, > .verify = exynos_verify_speed, > .target = exynos_target, > .get = exynos_getspeed, > .init = exynos_cpufreq_cpu_init, > + .exit = exynos_cpufreq_cpu_exit, > .name = CPUFREQ_NAME, > }; > > -- > 1.7.12.rc2.18.g61b472e > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html On Sat, Aug 10, 2013 at 12:13 PM, Viresh Kumar wrote: > Drivers which have an exit path must call cpufreq_frequency_table_put_attr() if > they have called cpufreq_frequency_table_get_attr() in their init path. > > This driver was missing this part and is fixed with this patch. > > Cc: Kukjin Kim > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/exynos5440-cpufreq.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c > index 1ac93e0..b9dfc91 100644 > --- a/drivers/cpufreq/exynos5440-cpufreq.c > +++ b/drivers/cpufreq/exynos5440-cpufreq.c > @@ -336,12 +336,18 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > return 0; > } > > +static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > +{ > + cpufreq_frequency_table_put_attr(policy->cpu); > +} > + > static struct cpufreq_driver exynos_driver = { > .flags = CPUFREQ_STICKY, > .verify = exynos_verify_speed, > .target = exynos_target, > .get = exynos_getspeed, > .init = exynos_cpufreq_cpu_init, > + .exit = exynos_cpufreq_cpu_exit, > .name = CPUFREQ_NAME, > }; > > -- > 1.7.12.rc2.18.g61b472e > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/