Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754659Ab3HRKyE (ORCPT ); Sun, 18 Aug 2013 06:54:04 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:44332 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155Ab3HRKyC (ORCPT ); Sun, 18 Aug 2013 06:54:02 -0400 MIME-Version: 1.0 In-Reply-To: <14993d27bdc6a91eced0af5eb96bdb5ca6546cbf.1376619363.git.viresh.kumar@linaro.org> References: <14993d27bdc6a91eced0af5eb96bdb5ca6546cbf.1376619363.git.viresh.kumar@linaro.org> Date: Sun, 18 Aug 2013 16:24:00 +0530 X-Google-Sender-Auth: nD4GwhFwaGxlFc0zFvZr74l1bXs Message-ID: Subject: Re: [PATCH 13/34] cpufreq: exynos5440: set CPUFREQ_NO_NOTIFICATION flag From: amit daniel kachhap To: Viresh Kumar Cc: "Rafael J. Wysocki" , linaro-kernel@lists.linaro.org, "patches@linaro.org" , cpufreq@vger.kernel.org, "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , LAK , Kukjin Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2274 Lines: 57 On Fri, Aug 16, 2013 at 7:55 AM, Viresh Kumar wrote: > Most of the drivers do following in their ->target_index() routines: > > struct cpufreq_freqs freqs; > freqs.old = old freq... > freqs.new = new freq... > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); > > /* Change rate here */ > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); > > This is replicated over all cpufreq drivers today and there doesn't exists a > good enough reason why this shouldn't be moved to cpufreq core instead. > > Earlier patches have added support in cpufreq core to do cpufreq notification on > frequency change, but this drivers needs to do this notification itself and so > it sets its CPUFREQ_NO_NOTIFICATION flag. > > Cc: Kukjin Kim > Signed-off-by: Viresh Kumar The code change looks fine, Acked-By: Amit Daniel Kachhap Thanks Amit Daniel > --- > drivers/cpufreq/exynos5440-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c > index 91a64d6..8fb6183 100644 > --- a/drivers/cpufreq/exynos5440-cpufreq.c > +++ b/drivers/cpufreq/exynos5440-cpufreq.c > @@ -323,7 +323,7 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > } > > static struct cpufreq_driver exynos_driver = { > - .flags = CPUFREQ_STICKY, > + .flags = CPUFREQ_STICKY | CPUFREQ_NO_NOTIFICATION, > .verify = cpufreq_generic_frequency_table_verify, > .target_index = exynos_target, > .get = exynos_getspeed, > -- > 1.7.12.rc2.18.g61b472e > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/