Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755646Ab3HRW5R (ORCPT ); Sun, 18 Aug 2013 18:57:17 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:40367 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754996Ab3HRW5Q convert rfc822-to-8bit (ORCPT ); Sun, 18 Aug 2013 18:57:16 -0400 From: "Kim, Milo" To: Bryan Wu CC: =?iso-8859-1?Q?Pali_Roh=E1r?= , Linux LED Subsystem , lkml , Milo Kim Subject: RE: [PATCH 01/10] leds: lp55xx: add common data structure for program Thread-Topic: [PATCH 01/10] leds: lp55xx: add common data structure for program Thread-Index: AQHOlA1Xw1EX7CXaFUe1LSqTxFyADZmS/1oAgAijZtA= Date: Sun, 18 Aug 2013 22:57:09 +0000 Message-ID: References: <1375948794-6286-1-git-send-email-milo.kim@ti.com> <1375948794-6286-2-git-send-email-milo.kim@ti.com> In-Reply-To: Accept-Language: en-US, ko-KR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.34.32] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 36 Hi Bryan, > -----Original Message----- > From: Bryan Wu [mailto:cooloney@gmail.com] > Sent: Wednesday, August 14, 2013 3:56 AM > To: Milo Kim > Cc: Pali Roh?r; Linux LED Subsystem; lkml; Kim, Milo > Subject: Re: [PATCH 01/10] leds: lp55xx: add common data structure for > program > > On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim wrote: > > LP55xx family devices have internal three program engines which are > > used for loading LED patterns. > > To maintain legacy device attributes, specific data structure is used, > 'mode' > > and 'led_mux'. > > The mode is used for showing/storing current engine mode such like > > disabled, load and run. > > Then led_mux is used for showing/storing current output LED selection. > > This is only for LP5523/55231. > > > > This patch looks good to me, but the commit message format is little bit odd > to me. I will fix that and merge into my tree. Thanks for your help. Can I get more detailed information about this format problem? I need to check my configurations. Thanks, Milo- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/