Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750978Ab3HSJgX (ORCPT ); Mon, 19 Aug 2013 05:36:23 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:55513 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836Ab3HSJgW (ORCPT ); Mon, 19 Aug 2013 05:36:22 -0400 MIME-Version: 1.0 In-Reply-To: <5211DD5C.1080306@inria.fr> References: <51F8F14C.8060507@inria.fr> <5211DD5C.1080306@inria.fr> Date: Mon, 19 Aug 2013 02:36:21 -0700 X-Google-Sender-Auth: iTNutUPjCTJXq-Omqr2gULcP7rA Message-ID: Subject: Re: dmaengine: make dma_channel_rebalance() NUMA aware From: Dan Williams To: Brice Goglin Cc: Vinod Koul , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 604 Lines: 16 > + for_each_online_cpu(cpu) > + per_cpu_ptr(channel_table[cap], cpu)->chan > + = min_chan(cap, cpu); ...this line-wrap strikes me weird. I think we can afford a few extra lines and do: for_each_online_cpu(cpu) { chan = min_chan(cap, cpu); per_cpu_ptr(channel_table[cap], cpu)->chan = chan; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/