Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751671Ab3HSMBU (ORCPT ); Mon, 19 Aug 2013 08:01:20 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:24013 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649Ab3HSMBR (ORCPT ); Mon, 19 Aug 2013 08:01:17 -0400 X-IronPort-AV: E=Sophos;i="4.89,913,1367964000"; d="scan'208";a="29736320" Date: Mon, 19 Aug 2013 14:00:37 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: =?ISO-8859-15?Q?Svenning_S=F8rensen?= cc: Felipe Balbi , kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource In-Reply-To: <521208A0.5010602@secomea.dk> Message-ID: References: <1376902316-18520-1-git-send-email-Julia.Lawall@lip6.fr> <1376902316-18520-5-git-send-email-Julia.Lawall@lip6.fr> <5211FED3.4090102@secomea.dk> <521208A0.5010602@secomea.dk> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-2032609312-1376913637=:2313" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 32 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2032609312-1376913637=:2313 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT On Mon, 19 Aug 2013, Svenning S?rensen wrote: > > On 19-08-2013 13:35, Julia Lawall wrote: > > reg_base = devm_ioremap_resource(dev, r); > > if (!musb->ctrl_base) > > return -EINVAL; > > > Not really related to Julia's patch, apart from making it more obvious > > > that > > > there's a bug here. > > > I believe it is reg_base that needs to be checked, right? > > Indeed, it is all backwards. I could extend the patch, if you want. > > > I'll let Felipe decide on that, but I can't imagine any objections. > IS_ERR() is the proper test, of course :) I've already sent a patch, in case it is useful. julia --8323329-2032609312-1376913637=:2313-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/