Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751213Ab3HSOh5 (ORCPT ); Mon, 19 Aug 2013 10:37:57 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:35686 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811Ab3HSOh4 (ORCPT ); Mon, 19 Aug 2013 10:37:56 -0400 Date: Mon, 19 Aug 2013 07:37:52 -0700 From: Christoph Hellwig To: Cong Wang Cc: netdev@vger.kernel.org, "David S. Miller" , Steve French , Christine Caulfield , David Teigland , Trond Myklebust , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org Subject: Re: [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions Message-ID: <20130819143752.GA12266@infradead.org> References: <1376907278-26377-1-git-send-email-amwang@redhat.com> <1376907278-26377-8-git-send-email-amwang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376907278-26377-8-git-send-email-amwang@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 12 > @@ -1900,17 +1901,9 @@ srcip_matches(struct sockaddr *srcaddr, struct sockaddr *rhs) > { I think your new sockaddr_equal should be equivalent to to this srcip_matches, that is it should warn about and return false for unknown address families. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/