Message-ID: <521245F0.3090905@wwwdotorg.org>
Date: Mon, 19 Aug 2013 10:21:04 -0600
From: Stephen Warren <swarren@wwwdotorg.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8
MIME-Version: 1.0
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
CC: balbi@ti.com, rob.herring@calxeda.com, pawel.moll@arm.com,
        mark.rutland@arm.com, ian.campbell@citrix.com, rob@landley.net,
        gregkh@linuxfoundation.org, grant.likely@linaro.org,
        idos@codeaurora.org, mgautam@codeaurora.org,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information
References: <1376485183-2664-1-git-send-email-iivanov@mm-sol.com>  <1376485183-2664-2-git-send-email-iivanov@mm-sol.com>  <520EAB3B.9030607@wwwdotorg.org> <1376915267.26268.16.camel@iivanov-dev.int.mm-sol.com>
In-Reply-To: <1376915267.26268.16.camel@iivanov-dev.int.mm-sol.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2008
Lines: 49

On 08/19/2013 06:27 AM, Ivan T. Ivanov wrote:
> 
> Hi, 
> 
> On Fri, 2013-08-16 at 16:44 -0600, Stephen Warren wrote: 
>> On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote:
>>> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>>>
>>> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys
>>> (SNPS) and HS, SS PHY's control and configuration registers.
>>>
>>> It could operate in device mode (SS, HS, FS) and host
>>> mode (SS, HS, FS, LS).
>>
>>> diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt b/Documentation/devicetree/bindings/usb/msm-ssusb.txt
>>
>>> +- clock-names :
>> ...
>>> +	"sleep_a_clk" : Sleep clock, used when USB3 core goes into low
>> ...
>>> +	"ref_clk" : Reference clock - used in host mode.
>> ...
>>> +	"core_clk" : Master/Core clock, have to be >= 125 MHz for SS
>> ...
>>> +	"iface_clk" : System bus AXI clock
>>> +	"sleep_clk" : Sleep clock, used when USB3 core goes into low
>> ...
>>> +	"utmi_clk" : Generated by HS-PHY. Used to clock the low power
>>
>> I think it makes sense to remove "_clk" from all those names, unless the
>> HW documentation really talks about a clock named e.g. iface_clk yet
>> some other clock names in the documentation don't have the "_clk"
>> suffix, e.g. the "xo I didn't quote.
> 
> From limited information that I have, I could not say how clock inputs 
> are named from the controller perspective, but I agree that "_clk"
> suffix looks redundant. 
> 
> Side question: if for example label in controller says "UTMI", should I
> also use capital letters for the resource or this could be "utmi"?

All the clock-names entries I've seen so far have been lower-case, but I
suppose there's no hard-and-fast rule that they couldn't be
upper-/mixed-case if that best matched the HW documentation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/