Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751592Ab3HSWou (ORCPT ); Mon, 19 Aug 2013 18:44:50 -0400 Received: from gate.crashing.org ([63.228.1.57]:42570 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470Ab3HSWos (ORCPT ); Mon, 19 Aug 2013 18:44:48 -0400 Message-ID: <1376952280.25016.87.camel@pasglop> Subject: Re: [PATCH] vfio-pci: PCI hot reset interface From: Benjamin Herrenschmidt To: Alex Williamson Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Alexander Viro , linux-fsdevel Date: Tue, 20 Aug 2013 08:44:40 +1000 In-Reply-To: <1376943632.2657.25.camel@ul30vt.home> References: <20130814200845.21923.64284.stgit@bling.home> <1376521578.13642.65.camel@ul30vt.home> <1376937682.2657.15.camel@ul30vt.home> <1376943632.2657.25.camel@ul30vt.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 23 On Mon, 2013-08-19 at 14:20 -0600, Alex Williamson wrote: > I try to handle the slot as opaque, only caring that the slot pointer > matches, so I think our implementation is ok... so long as we only get > one driver claiming to manage a slot, but that's not a vfio problem ;) > Thanks, By why bother with slots ? Why do you even think about slots in that context ? slots are a badly defined thing in our current PCI stack, pretty much intricated with hotplug. I don't see why the reset semantics would be tied to slots at all. The only case where it *might* make some sense (and even then ...) is if you want to start exposing slot power control and PERST but that would imply a pile of platform specific gunk anyway. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/