Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751655Ab3HSXaK (ORCPT ); Mon, 19 Aug 2013 19:30:10 -0400 Received: from mms2.broadcom.com ([216.31.210.18]:3895 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436Ab3HSXaI (ORCPT ); Mon, 19 Aug 2013 19:30:08 -0400 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Message-ID: <5212AA78.9040101@broadcom.com> Date: Mon, 19 Aug 2013 16:30:00 -0700 From: "Christian Daudt" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: "Christian Daudt" cc: "Chris Ball" , "Matt Porter" , "Markus Mayer" , "Arnd Bergmann" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, csd_b@daudt.org Subject: Re: [PATCH] ARM: mmc: fix NONREMOVABLE test in sdhci-bcm-kona References: <1375901981-1495-1-git-send-email-csd@broadcom.com> In-Reply-To: <1375901981-1495-1-git-send-email-csd@broadcom.com> X-WSS-ID: 7E0C76881R082171354-01-01 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 41 On 13-08-07 11:59 AM, Christian Daudt wrote: > sdhci-bcm-kona driver is incorrectly doing "|" to bit-test > NONREMOVABLE. Switch to "&" > > Reviewed-by: Markus Mayer > Reviewed-by: Matt Porter > Signed-off-by: Christian Daudt > > diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c > index 87175f9..9ffac0b 100644 > --- a/drivers/mmc/host/sdhci-bcm-kona.c > +++ b/drivers/mmc/host/sdhci-bcm-kona.c > @@ -263,7 +263,7 @@ static int __init sdhci_bcm_kona_probe(struct platform_device *pdev) > (mmc_gpio_get_cd(host->mmc) != -ENOSYS) ? 'Y' : 'N', > (mmc_gpio_get_ro(host->mmc) != -ENOSYS) ? 'Y' : 'N'); > > - if (host->mmc->caps | MMC_CAP_NONREMOVABLE) > + if (host->mmc->caps & MMC_CAP_NONREMOVABLE) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > > dev_dbg(dev, "is_8bit=%c\n", > @@ -282,7 +282,7 @@ static int __init sdhci_bcm_kona_probe(struct platform_device *pdev) > } > > /* if device is eMMC, emulate card insert right here */ > - if (host->mmc->caps | MMC_CAP_NONREMOVABLE) { > + if (host->mmc->caps & MMC_CAP_NONREMOVABLE) { > ret = sdhci_bcm_kona_sd_card_emulate(host, 1); > if (ret) { > dev_err(dev, applied to bcm/for-3.12/soc thanks, csd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/