Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534Ab3HSXiM (ORCPT ); Mon, 19 Aug 2013 19:38:12 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:50431 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229Ab3HSXiL (ORCPT ); Mon, 19 Aug 2013 19:38:11 -0400 From: "Rafael J. Wysocki" To: Jerry Snitselaar Cc: Mika Westerberg , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION Date: Tue, 20 Aug 2013 01:48:44 +0200 Message-ID: <1838503.PYpZe7GJ51@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.11.0-rc5+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <20130819233528.GA4587@cantor.us.oracle.com> References: <1376702795-25912-1-git-send-email-jerry.snitselaar@oracle.com> <2870377.GVGv4QBgQK@vostro.rjw.lan> <20130819233528.GA4587@cantor.us.oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 34 On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: > On Tue Aug 20 13, Rafael J. Wysocki wrote: > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > > > > > acpi_i2c: module license 'unspecified' taints kernel. > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > > > > > > > Signed-off-by: Jerry Snitselaar > > > > > > Looks good to me. > > > > > > Acked-by: Mika Westerbeg > > > > Well, OK, but do we need to be able to build that as a module? > > > > Maybe it should just be yes or no? > > > > Rafael > > > > Perhaps have depends on I2C=y and be a bool instead of tristate? Yes, that's the idea. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/