Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650Ab3HTBUz (ORCPT ); Mon, 19 Aug 2013 21:20:55 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:28606 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751326Ab3HTBUx (ORCPT ); Mon, 19 Aug 2013 21:20:53 -0400 X-IronPort-AV: E=Sophos;i="4.89,915,1367942400"; d="scan'208";a="8245676" Message-ID: <5212C426.7020006@cn.fujitsu.com> Date: Tue, 20 Aug 2013 09:19:34 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Toshi Kani CC: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, lenb@kernel.org, rjw@sisk.pl, liwanp@linux.vnet.ibm.com, tj@kernel.org, akpm@linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 6/6] acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment. References: <1376636809-10159-1-git-send-email-tangchen@cn.fujitsu.com> <1376636809-10159-7-git-send-email-tangchen@cn.fujitsu.com> <1376940579.10300.474.camel@misato.fc.hp.com> In-Reply-To: <1376940579.10300.474.camel@misato.fc.hp.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/20 09:19:08, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/20 09:19:09, Serialize complete at 2013/08/20 09:19:09 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 27 On 08/20/2013 03:29 AM, Toshi Kani wrote: > On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote: >> The comment about return value of acpi_table_parse() is incorrect. >> This patch fix it. >> >> Furthermore, if the table is not found, return 1 means nothing, and >> make it difficult to write the comment. So return -ENOENT when the >> table is not found, and correct the comment. > > I am OK with the change, but the above description is not very clear. > You should state that all callers only check if the function succeeded > or not. So, you are simplifying the semantics by returning -errno for > all failure cases. > > Since you are making this change, I'd suggest you also update the stub > function in linux/acpi.h to return -ENODEV as well. OK, followed. And will merge patch 3 and 4 and resend them later. Thanks for reviewing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/