Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336Ab3HTGZl (ORCPT ); Tue, 20 Aug 2013 02:25:41 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:41826 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225Ab3HTGZk (ORCPT ); Tue, 20 Aug 2013 02:25:40 -0400 MIME-Version: 1.0 In-Reply-To: References: <1376929831-18214-1-git-send-email-richard.genoud@gmail.com> From: Richard Genoud Date: Tue, 20 Aug 2013 08:25:19 +0200 Message-ID: Subject: Re: [PATCH] proc: return on proc_readdir error To: Marc Dionne Cc: Linus Torvalds , Al Viro , Andrew Morton , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 33 2013/8/20 Marc Dionne : > On Mon, Aug 19, 2013 at 7:49 PM, Linus Torvalds > wrote: >> On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne wrote: >>> >>> By my reading that commit (f0c3b5093add) also made proc_readdir always >>> return 0, so with this patch the effect I see is that no pid entries >>> are listed under /proc, breaking ps for instance. I don't see how >>> even the previous version of proc_readdir could return a negative >>> value; looks like 1 and 0 were the only possible return values. >> >> Yes, see the other thread. The "return 1" case had gotten lost. I >> think current git should get everything right, but please do test. I >> did some testing of my own with a random little getdents test-program >> (just checking that it got the same results with different (small) >> buffer sizes), but it was by no means exhaustive. >> >> Linus > > It does fix the symptoms I was seeing, thanks. "ps" now has output > and the pid entries are now visible again under /proc. > > Marc arg ! I was so focused on getting the non-PID proc entries right that I didn't even see all the missing PIDs when I tested it ! /me need holidays. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/