Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751265Ab3HTMIH (ORCPT ); Tue, 20 Aug 2013 08:08:07 -0400 Received: from mail-ea0-f179.google.com ([209.85.215.179]:58301 "EHLO mail-ea0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180Ab3HTMIG (ORCPT ); Tue, 20 Aug 2013 08:08:06 -0400 Date: Tue, 20 Aug 2013 13:08:00 +0100 From: Lee Jones To: Florian Lobmaier Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com Subject: Re: [PATCH 4/4] mfd: as3722: introduce regmap support Message-ID: <20130820120800.GN23699@lee--X1> References: <1376997210-32631-1-git-send-email-florian.lobmaier@ams.com> <1376997210-32631-5-git-send-email-florian.lobmaier@ams.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1376997210-32631-5-git-send-email-florian.lobmaier@ams.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 25 On Tue, 20 Aug 2013, Florian Lobmaier wrote: > > Signed-off-by: Florian Lobmaier > --- > drivers/mfd/as3722-regmap.c | 417 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 417 insertions(+), 0 deletions(-) > create mode 100644 drivers/mfd/as3722-regmap.c I'll leave the review of this file to Mark, but it should be added either when you start calling the functions, or at least before they are used, or else the preceding commits won't build. This would cause someone a major headache if their bisect landed in the middle of your patches. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/